Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: logocloud #961

Merged
merged 2 commits into from
Dec 27, 2024
Merged

refactor: logocloud #961

merged 2 commits into from
Dec 27, 2024

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Dec 26, 2024

Problem

  1. logocloud requires assetsBaseUrl for relative links but site already has this - we should account for this and just derive it from site
  2. studio uses title to render so now for logocloud it's showing Title (see SS)

Solution

  1. update logocloud from using assetsBaseUrl to using site.assetsBaseUrl
  2. update title in the schema to Logocloud component

How to test

  1. open up studio
  2. add a logocloud component
  3. add a relative url
  4. the image shuold render without issue
  5. for the title, it shuold display logocloud component

Migration plan

  • none -> because now it's no longer picking up the property post release and it's isntead deriving from sites.

screenshots

image
Screen.Recording.2024-12-26.at.11.25.49.PM.mov

don't ask consumers for assetsbaseurl but ask for site instead
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 26, 2024

Datadog Report

Branch report: refactor/logo-cloud
Commit report: 3e20e0f
Test service: isomer-studio

✅ 0 Failed, 245 Passed, 36 Skipped, 46.46s Total Time
➡️ Test Sessions change in coverage: 1 no change

Copy link
Contributor

@adriangohjw adriangohjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need fix Logocloud storybook to pass in the right args

@adriangohjw adriangohjw merged commit 47d5dd6 into main Dec 27, 2024
20 checks passed
@adriangohjw adriangohjw deleted the refactor/logo-cloud branch December 27, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants